Expand HandleNullBytes to handle malformed strings

What does this MR do?

Expands the HandleNullBytes middleware to also handle malformed strings. Changes the middleware to return ActionController::BadRequest so we use the default Rails bad request handling.

NOTE: since handling malformed strings is done by guarding against a raise, I elected not to rename the middleware.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #257822

Edited by Mario de la Ossa

Merge request reports

Loading