Skip to content

Consolidate incident SLA component

Tristan Read requested to merge tr-consolidate-incident-sla-component into master

What does this MR do?

Creates a shared component for the Incident SLA. The SLA is currently shown in two places - Incident list and individual Incident page.

This lays the groundwork for future SLA improvements:

It also makes the tooltips match between usages.

Testing

There are two places to test:

They look like this:

incident list view incident detail view
Screenshot_2021-01-25_at_13.46.17 Screenshot_2021-01-25_at_13.45.38

To get this running in your GDK / the review app, follow these instructions:

  1. Have a GitLab Premium license or above.
  2. Set up the SLA as per these instructions: https://docs.gitlab.com/ee/operations/incident_management/incidents.html#service-level-agreement-countdown-timer
  3. Configure the alert endpoint: https://docs.gitlab.com/ee/operations/incident_management/alert_integrations.html#single-http-endpoint
    • The generic HTTP integration is the fastest for this purpose - switch it on and grab the URL and auth-token.
  4. Trigger an alert: scroll down to the curl requests for an example, modify the URL and Authorization to match the previous step and run in a terminal window.
  5. Lastly, promote the alert to an incident(if the incident auto-creation is not already configured).

The SLA should now appear in the incident list and incident detail view.

Screenshots

None - no change.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [n/a] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [n/a] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tristan Read

Merge request reports