Skip to content

Generate a longer agentk token by default

Hordur Freyr Yngvason requested to merge use-longer-agentk-token into master

What does this MR do?

Increases the length of newly created tokens from 20 to 50 characters to make it possible to use the token prefix as a unique-enough key for rate limiting while keeping the suffix fully secret.

We are probably also going to switch to a digest-based token, but that is a breaking change and needs just a bit more planning, so it will be a separate MR.

See #270218 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Thong Kuah

Merge request reports