Skip to content

Banzai handle removed references

Heinrich Lee Yu requested to merge banzai-handle-removed-references into master

What does this MR do?

When we reverted vulnerability references in !45284 (merged), we forgot to bump the Markdown cache. So we have stale vulnerability references in the Markdown HTML cache in the database.

This caused the ReferenceRedactor to fail because it was looking for VulnerabilityParser which no longer exists.

This MR bumps the Markdown cache so that we don't have stale HTML and also changes the redactor so that it handles non-existent types gracefully. These links just get redacted like references that the user does not have access to.

gitlab-com/gl-infra/production#2837 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński

Merge request reports