replaced GlDeprecatedBadge with GlBadge for form.vue
What does this MR do?
Hi everybody,
I replaced the GlDeprecatedBadge with the GlBadge to solve this issue.
See screenshots attached.
On viewports smaller than 767px I'm seeing some issues regarding the layout and the badge overflowing to the right of the container. I've opened this Issue for it.
Note:
gitlab/app/assets/javascripts/feature_flags/components/form.vue L-421 has variant="success" on it, this variant does not occur
in the given mapping guide, since variant="success" is a valid variant of in GlDeprecatedBadge as well as in GlBadge https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-badge--default I expected this to stay this way.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #219532 (closed)