Skip to content

Fix broken suggest pipeline emoji

What does this MR do?

Fixes rendering issue with celebration emoji on suggest pipeline success.

Note: feature still behind experiment/feature flag, so no changelog.

Screenshots

before after
Screen_Shot_2020-10-15_at_4.15.09_PM Screen_Shot_2020-10-15_at_4.18.38_PM

How to easily verify locally

  • add return true as first line in this method
  • visit any file in a repo and append force experiment param like this http://127.0.0.1:3000/h5bp/html5-boilerplate/-/blob/master/.travis.yml?force_experiment=suggest_pipeline

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #268017

Edited by Doug Stull

Merge request reports