Fix broken suggest pipeline emoji
What does this MR do?
Fixes rendering issue with celebration emoji on suggest pipeline success.
Note: feature still behind experiment/feature flag, so no changelog.
Screenshots
before | after |
---|---|
![]() |
![]() |
How to easily verify locally
- add
return true
as first line in this method - visit any file in a repo and append
force experiment
param like thishttp://127.0.0.1:3000/h5bp/html5-boilerplate/-/blob/master/.travis.yml?force_experiment=suggest_pipeline
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #268017
Edited by Doug Stull