Skip to content

Convert bootstrap alert to gl for project size limit

Alexander Turinske requested to merge 233682-bootstrap-alert-size-limit into master

What does this MR do?

Convert bootstrap alert to gl for project size limit

Screenshots

Before After
image Screen_Shot_2020-10-15_at_12.34.09_PM

How to reproduce

  1. Modify the code below
diff --git a/ee/app/views/projects/_above_size_limit_warning.html.haml b/ee/app/views/projects/_above_size_limit_warning.html.haml
index e4487c08af0..8d3a11364eb 100644
--- a/ee/app/views/projects/_above_size_limit_warning.html.haml
+++ b/ee/app/views/projects/_above_size_limit_warning.html.haml
@@ -1,5 +1,4 @@
- if size_checker.above_size_limit?
+ if !size_checker.above_size_limit?
  1. Navigate to a project

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #233682 (closed) Related to gitlab-com/www-gitlab-com#8498 (closed)

Edited by Alexander Turinske

Merge request reports