Fix rate limiter cache keys without ttl
What does this MR do?
During our production usage, we encountered a bug with issue creation API. The rate limiter is increased to > 10k but with ttl -1. Although there's no direct evidence of the cause of this bug, I think the current code wont' handle the case gracefully where redis incr command failed to return to client but succeeded at server side.
This MR tries to mitigate this issue by check the TTL of cache key and automatically fix it. It will send more traffic to redis server, but given the difficulty of identifying the issue and mitigating it manually, I think it worth the cost.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team