Skip to content

MR Analytics - Throughput chart - Prettify tooltip title

What does this MR do?

This MR fixes a minor styling issue where the chart tooltip title contained an underscore between the abbreviated month and year.

In order to simplify testing this change, the chart data transformation has been extracted out of the chart component and moved into a util. This allows us to unit test the transformation without testing Vue internals.

How to test:

  1. Make sure you have starter plan.
  2. Enable the feature: Feature.enable(:project_merge_request_analytics)
  3. Navigate to the page: some project / analytics / Merge Requests
  4. You should see the page as depicted by the screenshot

Screenshots

Before After
Screenshot_2020-10-15_at_05.30.22 Screenshot_2020-10-15_at_05.29.09

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #250670 (closed)

Edited by Brandon Labuschagne

Merge request reports