Skip to content

Store test failure data when build finishes

Erick Bajao requested to merge eb-test-failure-history-mvc into master

What does this MR do?

This is part of the work for #241759 (closed)

Originally based on the PoC MR: !44047 (closed)

The work is split into 2 MRs:

  1. Storing the failure data (This MR)
  2. Fetching the failure data (!45187 (merged))

DB Migration Output

~/gdk-ee/gitlab bundle exec rake db:migrate db:test:prepare

== 20201012134230 CreateCiTestCases: migrating ================================
-- table_exists?(:ci_test_cases)
   -> 0.0006s
-- create_table(:ci_test_cases)
   -> 0.0128s
-- transaction_open?()
   -> 0.0000s
-- current_schema()
   -> 0.0002s
-- execute("ALTER TABLE ci_test_cases\nADD CONSTRAINT check_dd3c5d1c15\nCHECK ( char_length(key_hash) <= 64 )\nNOT VALID;\n")
   -> 0.0005s
-- current_schema()
   -> 0.0002s
-- execute("SET statement_timeout TO 0")
   -> 0.0002s
-- execute("ALTER TABLE ci_test_cases VALIDATE CONSTRAINT check_dd3c5d1c15;")
   -> 0.0004s
-- execute("RESET ALL")
   -> 0.0002s
== 20201012134230 CreateCiTestCases: migrated (0.0244s) =======================

== 20201012135330 CreateCiTestCaseFailures: migrating =========================
-- create_table(:ci_test_case_failures)
   -> 0.0069s
== 20201012135330 CreateCiTestCaseFailures: migrated (0.0069s) ================

== 20201012140110 AddProjectsFkToCiTestCases: migrating =======================
-- add_foreign_key(:ci_test_cases, :projects, {:column=>:project_id, :on_delete=>:cascade})
   -> 0.0038s
== 20201012140110 AddProjectsFkToCiTestCases: migrated (0.0053s) ==============

== 20201012140452 AddCiBuildsFkToCiTestCaseFailures: migrating ================
-- add_foreign_key(:ci_test_case_failures, :ci_builds, {:column=>:build_id, :on_delete=>:cascade})
   -> 0.0029s
== 20201012140452 AddCiBuildsFkToCiTestCaseFailures: migrated (0.0042s) =======

rollback:

~/gdk-ee/gitlab bundle exec rake db:rollback STEP=4

== 20201012140452 AddCiBuildsFkToCiTestCaseFailures: reverting ================
-- remove_foreign_key(:ci_test_case_failures, {:column=>:build_id})
   -> 0.0043s
== 20201012140452 AddCiBuildsFkToCiTestCaseFailures: reverted (0.0087s) =======

== 20201012140110 AddProjectsFkToCiTestCases: reverting =======================
-- remove_foreign_key(:ci_test_cases, {:column=>:project_id})
   -> 0.0027s
== 20201012140110 AddProjectsFkToCiTestCases: reverted (0.0039s) ==============

== 20201012135330 CreateCiTestCaseFailures: reverting =========================
-- drop_table(:ci_test_case_failures)
   -> 0.0012s
== 20201012135330 CreateCiTestCaseFailures: reverted (0.0012s) ================

== 20201012134230 CreateCiTestCases: reverting ================================
-- drop_table(:ci_test_cases)
   -> 0.0016s
== 20201012134230 CreateCiTestCases: reverted (0.0017s) =======================

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Erick Bajao

Merge request reports