Skip to content

Resolve "Analytics date picker labels are not centre aligned"

What does this MR do?

This MR sets the label class for the shared analytics daterange component. It also removes some of the CSS which was previously used to apply the styles we're adding via classes.

How to test:

  1. Make sure you have starter plan.
  2. Enable the feature: Feature.enable(:project_merge_request_analytics)
  3. Navigate to the page: some project / analytics / Merge Requests
  4. You should see the page as depicted by the screenshot

This requires changes from gitlab-ui!1790 (merged)

Screenshots

MR Analytics

Before After
Mobile Screenshot_2020-10-14_at_16.05.32 Screenshot_2020-10-14_at_16.00.08
Desktop Screenshot_2020-10-14_at_16.08.56 Screenshot_2020-10-14_at_16.10.30

VSA

Before After
Mobile Screenshot_2020-10-14_at_16.05.25 Screenshot_2020-10-14_at_15.59.46
Desktop Screenshot_2020-10-14_at_16.08.46 Screenshot_2020-10-14_at_16.10.22

Productivity Analytics

Before After
Mobile Screenshot_2020-10-14_at_16.05.29 Screenshot_2020-10-14_at_15.59.54
Desktop Screenshot_2020-10-14_at_16.08.51 Screenshot_2020-10-14_at_16.10.27

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #259647 (closed)

Edited by Brandon Labuschagne

Merge request reports