Skip to content

Draft: Avoid RSpec stubbing in commit factory

Peter Leitzen requested to merge pl-avoid-stub-commit-factory into master

What does this MR do?

Stubbing does not play well with test-prof's let_it_be. Allow setting author via a commit subclass used by the factory.

Potentially contributes to https://gitlab.com/gitlab-org/plan/-/issues/145.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports