Skip to content

Add new Cop to enforce object_from_id expected_type param

Mario de la Ossa requested to merge object_from_id_rubocop into master

What does this MR do?

Now that !44073 (merged) is merged, let's add a RuboCop cop to ensure this doesn't happen in our codebase again :)

The cop checks inside all graphql paths and will error out any call to GitlabSchema.object_from_id without an expected_type argument.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports