Skip to content

Step 2 - IDE Create a `editor` module for file editor properties

Paul Slaughter requested to merge 222507-ide-move-file-editor-props into master

What does this MR do?

This MR moves some editor specific properties away from the file object used in the IDE state.

  • fileLanguage
  • editorRow
  • editorColumn
  • viewMode

These properties are only needed for files that are actually opened in the monaco editor It's really wasteful for us to include them for every file in the file tree (even folders 😱)

Okay Paul, but what about the other properties mentioned in #222507 (closed)?

Those other properties might not actually fit in this new editor module. For the sake of iteration it's probably best to handle it in a separate more focused issue. Also see this relevant comment.

Screenshots

There are no visual changes and everything still works 😄

Screen_Shot_2020-10-20_at_9.12.15_PM

But! Here's a screenshot of the before/after memory snapshot of opening the Web IDE for the GitLab project 🎉

Before (on master) After (this MR)
Screen_Shot_2020-10-21_at_4.08.09_AM Screen_Shot_2020-10-21_at_4.15.58_AM

Does this MR meet the acceptance criteria?

Conformity

References

Edited by Paul Slaughter

Merge request reports