Step 2 - IDE Create a `editor` module for file editor properties
- Step 1 - Add feature specs for IDE editor info
- Step 2 - IDE Create a
editor
module for file editor properties
What does this MR do?
This MR moves some editor specific properties away from the file object used in the IDE state.
fileLanguage
editorRow
editorColumn
viewMode
These properties are only needed for files that are actually opened in the monaco editor
Okay Paul, but what about the other properties mentioned in #222507 (closed)?
Those other properties might not actually fit in this new editor
module. For the sake of iteration it's probably best to handle it in a separate more focused issue. Also see this relevant comment.
Screenshots
There are no visual changes and everything still works
But! Here's a screenshot of the before/after memory snapshot of opening the Web IDE for the GitLab project
Before (on master ) |
After (this MR) |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
[ ] Changelog entryThere are no user facing changes here. -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
References
- Related to #222507 (closed)