Memoize repository storage shard in GroupWiki
What does this MR do?
This caused a bug where sometimes one shard was used for the repository
creation in Wiki#create_wiki_repository
, but then a different one was
persisted to the DB in GroupWiki#create_wiki_repository
.
So subsequent requests would use the wrong shard, and run into
Gitlab::Git::Repository::NoRepository
errors.
Note: Group wikis are still behind a feature flag, so no changelog was added for this bugfix.
Ref: #263416 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team