Skip to content

Fix regression when uploading / viewing binary files in the Web IDE

Himanshu Kapoor requested to merge himkp-webide-binary-regression into master

What does this MR do?

Currently when you upload a binary file or an image, the Web IDE renders it as base 64 content instead of rendering the image/download viewers for this file. Potentially caused after merging !42393 (merged).

Screenshots

Case Current State Expected state after this MR
Uploading an image image image
Uploading a binary file. Note the blob url in the footer image image
Open existing binary file. Note the actual raw url url in the footer image image
Open existing image file image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Himanshu Kapoor

Merge request reports