Skip to content

Add limit to number of test cases parsed

Erick Bajao requested to merge eb-limit-test-cases-parsed into master

What does this MR do?

Solves #247886 (closed)

Related discussion: #247886 (comment 418666939)

Adds a hardcoded limit that only applies to .com. This is for the max number of test cases allowed to be parsed by the JUnit parser. If the limit is exceeded, an error message will be displayed on the MR widget.

Unfortunately, we can't rely on test_suite.total_count as basis for test cases parsed because it counts test cases uniquely by their key(classname + name). So if there's a malicious file that contains just a bunch of duplicate test cases, we won't be able to catch it.

Screenshots

Screen_Shot_2020-10-08_at_1.37.38_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Erick Bajao

Merge request reports