Skip to content

Add n+1 spec for namespaces API as admin user

Reuben Pereira requested to merge rp/add-namespaces-n+1-spec-for-admins into master

What does this MR do?

This MR:

  1. Adds an n+1 spec that calls the namespaces API as an admin user.
  2. Modifies the existing n+1 spec (that uses a regular user) to create a group that the user does not have access to. It should not (and does not) increase the number of SQL queries.
  3. Change the existing spec to call the API once before calling the query recorder (before the control recorder and before the subsequent recorder as well). This is so that any one-off "initialization" queries do not get counted.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Reuben Pereira

Merge request reports