Skip to content

Make Alert::STATUSES constant private

What does this MR do?

Contributes #231349 (closed)

Encapsulate Alert's status implementation details. Provide methods to operate with the Alert's status by its name instead of raw values.

Good news are that we don't need to introduce breaking changes to GraphQL, because GraphQL queries and mutations already operate with the status names instead of raw values. Raw values were used only internally.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports