Skip to content

Global Search - Dropdown Filters

Zack Cuddy requested to merge 262056-dropdown-filter-rewrite into master

What does this MR do?

Closes #262056 (closed)

This change introduces a top level Search Vuex Store that will be shared between the upcoming Search components.

This change also cleans up the implementation of the Dropdown filter to be Data-Driven. The files were a little spread out and it was hard to see from the file explorer the connection. This change brings them all into the same folder and creates data folders for the data-driven aspects of the components

Screenshots

header Before After (identical)
Search UI Before After

GIF

Existing functionality works Kapture_2020-10-02_at_11.20.08

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports