Skip to content

Improve selection_summary_spec.js tests

Kev requested to merge KevSlashNull/gitlab:improve-selection_summary-spec into master

What does this MR do?

This MR improves the ee/spec/frontend/security_dashboard/components/selection_summary_spec.js for ee/app/assets/javascripts/security_dashboard/components/selection_summary.vue. It switches to async/await (for better readability) and replaces the ref attribute in the component (which was exclusively used in the test) with a data-testid one.

The changes are based on the feedback/suggestions in !44213 (merged).

Screenshots

image

The component can be found by going to a vulnerability list and selecting vulnerabilities. (There are no visual changes.)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Martin Wortschack

Merge request reports