Skip to content

Update predicate to check read_licenses claim

mo khan requested to merge 208723-load-license-url into master

What does this MR do?

This MR fixes a defect that prevents the loading of license_scanning data that is incorrectly being blocked by the :read_build claim. The read_build claim does not account for reading license scan reports produced from pipelines that belong to a forked project. The read_build claim is applied here.

Screenshots

Before:

screenshot-2020-10-06-1602022251

After:

screenshot-2020-10-06-1602022472

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #208723 (closed)

Edited by Michael Kozono

Merge request reports