Skip to content

Return nil when fetching a wiki page with invalid arguments

Markus Koller requested to merge 222699-wiki-find-page-empty-title into master

What does this MR do?

Gitaly returns a GRPC::InvalidArgument response in certain cases, such as empty titles or versions containing invalid characters.

On the Rails side we don't want to raise an error in this case, but treat it the same as if a wiki page could not be found.

Ref: #222699 (closed), #225196 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Markus Koller

Merge request reports