WIP: Global Search - Port Dropdown Filters
Why WIP
-
Merge target MR !44176 (closed) -
Tests
What does this MR do?
Closes #262056 (closed)
This MR is split off (2 of 2) from !43927 (closed)
This change ports over the Status and Confidentiality Filter into the Vue App created as part of !44176 (closed)
Originally these two components initialized their own Vue instance and were not aware of each other. Now with this new strategy they are all part of the same instance and can communicate between the same Vuex store.
Changes to existing components
These components utilize a generalized component dropdown_filter.vue
. This component is data-driven by their specific constants files. These constant files control what the dropdown items are and what query param they affect. More can be seen in the search/constants.js
file.
Screenshots
header | Before | After (identical) |
---|---|---|
Search UI |
GIF
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team