Skip to content

Merge graphql logs with application(controller) logs

Mehmet Emin INAC requested to merge merge_graphql_logs_with_server_logs into master

What does this MR do?

This MR merges the GraphQL logs into application logs except the duration_s and query_string.

Why do we need to merge GraphQL logs into application logs?

Since we don't have a parent-child mapping for our documents on Elasticsearch, there is no way to query application logs along with the GraphQL logs which makes it really hard to build useful graphs on Kibana and debug the issues.

What should we do with the existing graphql_json.log file

Since this is a documented feature, IMHO we should first deprecate this file in a separate MR and then remove it with the next release.

Why duration_s and query_string is not merged?

The field duration_s is currently measuring the wrong thing which is only the time spent on the analyzer and not the query execution time. Also, query_string is already available in the application logs.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mehmet Emin INAC

Merge request reports