RuboCop: Allow `add_foreign_key` within `with_lock_retries`
What does this MR do?
This MR refines the Migration/AddConcurrentForeignKey
to allow add_foreign_key
within with_lock_retries
.
Closes #260317 (closed)
Note, this MR also remove most existing offenses but we still have a few which are very likely valid:
add_foreign_key(:ip_restrictions, :namespaces, column: :group_id, on_delete: :cascade) # rubocop: disable Migration/AddConcurrentForeignKey
# rubocop: disable Migration/AddConcurrentForeignKey
# rubocop:disable Migration/AddConcurrentForeignKey
# rubocop:enable Migration/AddConcurrentForeignKey
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides - [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen