[RUN AS-IF-FOSS] Add Incident SLA to Operations Settings
What does this MR do?
Adds Incident SLA as a tab to the Incident Management section of the Operations settings page.
Issue: #241663 (closed)
In this MR:
- New settings for Incident SLA in the db, controller and UI.
- Validation (frontend and backend).
In later MRs:
- Adding system notes and labels.
- Surfacing the remaining time in issues.
- Docs link.
- Usage tracking.
To Test
Pre-requisites:
- A license of Premium or above.
- Enable the
incident_sla_dev
feature flag. - Permissions of Maintainer or above for a project.
Reproduction steps:
- Open your project.
- Navigate to Settings -> Operations -> Incidents.
- Select the new Incident Settings tab.
Migration UP/DOWN:
up
rake db:migrate:up VERSION=20200929032729
== 20200929032729 AddSlaMinutesToProjectIncidentManagementSettings: migrating =
-- add_column(:project_incident_management_settings, :sla_timer, :boolean, {:default=>false})
-> 0.0024s
-- add_column(:project_incident_management_settings, :sla_timer_minutes, :integer)
-> 0.0003s
== 20200929032729 AddSlaMinutesToProjectIncidentManagementSettings: migrated (0.0028s)
down
rake db:migrate:down VERSION=20200929032729
== 20200929032729 AddSlaMinutesToProjectIncidentManagementSettings: reverting =
-- remove_column(:project_incident_management_settings, :sla_timer)
-> 0.0022s
-- remove_column(:project_incident_management_settings, :sla_timer_minutes)
-> 0.0009s
== 20200929032729 AddSlaMinutesToProjectIncidentManagementSettings: reverted (0.0032s)
Screenshots
new section |
---|
UI validation states | |||
---|---|---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Tristan Read