Skip to content

Validate text limit on designs.filename

Luke Duncalfe requested to merge 220420-migration-validate-designs-filename-text-limit into master

What does this MR do?

This MR adds validates the text limit constraint on design_management_designs.filename.

The text limit was added in %13.1 !33565 (merged).

Our database migration guidelines for text limit constraints are that we validate the constraint at least one release after the constraint was added.

Migration output

up

bundle exec rake db:migrate:up VERSION=20201001022100
== 20201001022100 ValidateDesignsFilenameTextLimit: migrating =================
-- current_schema()
   -> 0.0003s
-- execute("SET statement_timeout TO 0")
   -> 0.0002s
-- execute("ALTER TABLE design_management_designs VALIDATE CONSTRAINT check_07155e2715;")
   -> 0.0005s
-- execute("RESET ALL")
   -> 0.0002s
== 20201001022100 ValidateDesignsFilenameTextLimit: migrated (0.0027s) ========

down

As per https://docs.gitlab.com/ee/development/database/strings_and_the_text_data_type.html#validate-the-text-limit-next-release the down is a no-op.

bundle exec rake db:migrate:down VERSION=20201001022100
== 20201001022100 ValidateDesignsFilenameTextLimit: reverting =================
== 20201001022100 ValidateDesignsFilenameTextLimit: reverted (0.0000s) ========

Rollback

As per https://docs.gitlab.com/ee/development/database/strings_and_the_text_data_type.html#validate-the-text-limit-next-release the down is a no-op and cannot be reversed.

Does this MR meet the acceptance criteria?

Conformity

Edited by Luke Duncalfe

Merge request reports