Skip to content

Add API Fuzzing plan limits db column

Michael Eddington requested to merge 258203-add-api-fuzzing-plan-limits-db into master

What does this MR do?

Add a new column ci_max_artifact_size_api_fuzzing to the plan_limits database table. This field is required to add support for the new API Fuzzing report type.

Addresses #258203 (closed)

This MR follows the guidelines for adding new plan limits.

Default plan limits for security reports are currently 0.

Migration up:

$ bundle exec rake db:migrate
(in /home/mike/gdk/gitlab)
== 20200930132319 AddApiFuzzingToPlanLimits: migrating ========================
-- add_column(:plan_limits, "ci_max_artifact_size_api_fuzzing", :integer, {:default=>0, :null=>false})
   -> 0.0027s
== 20200930132319 AddApiFuzzingToPlanLimits: migrated (0.0028s) ===============

Migration down:

$ bundle exec rake db:migrate:down VERSION=20200930132319
(in /home/mike/gdk/gitlab)
== 20200930132319 AddApiFuzzingToPlanLimits: reverting ========================
-- remove_column(:plan_limits, "ci_max_artifact_size_api_fuzzing", :integer, {:default=>0, :null=>false})
   -> 0.0014s
== 20200930132319 AddApiFuzzingToPlanLimits: reverted (0.0060s) ===============

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Michael Eddington

Merge request reports