Draft: Convert unbounded varchar columns to text
What does this MR do?
Related issue: #271123
As part of the related issue, a script was used to capture all the schema differences between the expected (structure.sql) and actual (GitLab.com production database). One of the common differences was varchar columns being unbounded in structure.sql while being defined with a maximum length in the production database.
Since we can't reason about the status of self-managed installations and add a limit where there was none previously, the safest thing to do to make all the columns unbounded. As text is the preferred data type over varchar, we'd prefer to convert straight to text.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team