Fix N+1 cache queries for load_balancing
What does this MR do?
It turned out that N+1 cached queries are caused by Gitlab::Database::LoadBalancing::Sticking.
The number of N+1 cached queries was directly proportional to the number of group members, because primary_write_location
executed this query every time.
This MR prevents executing the same query multiple times during the same request.
Closes https://gitlab.com/gitlab-org/gitlab/-/issues/254219
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #254219
Edited by Kamil Trzciński (Back 2025-01-01)