Skip to content

Documentation: Add a warning about rules:changes with no PushEvent

drew stachon requested to merge add-changes-warning-to-docs into master

What does this MR do?

This MR adds a warning about the behavior of rules:changes in the context of pipelines with no PushEvent, and also details how those pipelines can be selected for and against in CI configuration by using CI_PIPELINE_SOURCE. This has been confusing for quite awhile, but I was recently pointed to a specific section of the documentation that seemed appropriate for the warning. (Thanks @hartzell!)

There's much more about this in the only:changes section, but as rules: is the prescribed configuration method going forward, I think it makes sense to add a concise warning here.

Related issues

#25855 (closed)

Author's checklist (required)

Do not add the feature, frontend, backend, ~"bug", or database labels if you are only updating documentation. These labels will cause the MR to be added to code verification QA issues.

When applicable:

Review checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.

1. Primary Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

2. Technical Writer

  • Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage.
    • Ensure docs metadata are present and up-to-date.
    • Ensure Technical Writing and documentation are added.
    • Add the corresponding docs:: scoped label.
    • Add twdoing when starting work on the MR.
    • Add twfinished if Technical Writing team work on the MR is complete but it remains open.

3. Maintainer

  1. Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  2. Ensure a release milestone is set.
  3. If there has not been a technical writer review, create an issue for one using the Doc Review template.
Edited by drew stachon

Merge request reports

Loading