Skip to content

Removed usages of gma_member_cleanup flag

Aishwarya Subramanian requested to merge remove_gma_member_cleanup_flag into master

What does this MR do?

Initially, when a group was converted to GMA the existing members were removed from the group.

!29425 (merged) introduced the changes to retain the group members after the conversion.

We introduced the gma_member_cleanup flag in case we wished to rollback to removing the group members.

Screen_Shot_2020-09-29_at_3.20.59_PM

Since the flag was never enabled on production and staging ever since it was introduced, I think it's safe to remove the flag as well as the code related to removal of group members on GMA conversion.

FF updates related to #251080 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Aishwarya Subramanian

Merge request reports