Skip to content

Fix Ruby 2.7 warnings for MergeabilityCheckService

Patrick Bajao requested to merge pb-mergeability-check-kwargs into master

What does this MR do?

In Ruby 3.0, positional arguments and keyword arguments will be separated. In Ruby 2.7, deprecation warnings related to keyword arguments show up.

Since #in_lock expects keyword arugments, explicitly specify passing keyword arguments instead of a Hash object by using double splat operator.

Related to #257438 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Patrick Bajao

Merge request reports