Skip to content

Update usage quotas table

Dhiraj Bodicherla requested to merge usage-quotas-table-without-details-row into master

What does this MR do?

This MR adds a modified/new version of Usage Quotas table in the user profile/group profile pages. The changes are behind additional_repo_storage_by_namespace feature flag. In this iteration the below are changed:

  1. Removes collapsible table rows
  2. Removes the details section under the table rows
  3. Adds error state (warning in another MR) for table rows
  4. Adds error icon for table rows with error state

How to test in local

Run the below code in bin/rails c and the navigate to localhost/groups/gitlab-org/-/usage_quotas#storage-quota-tab

Feature.enable(:namespace_storage_limit)
Feature.enable(:additional_repo_storage_by_namespace)
p = Project.where(name: 'Gitlab Shell')[0]
p.statistics&.destroy!
ps = ProjectStatistics.new(
  project_id: p.id,
  namespace_id: 89,
  commit_count: 12,
  storage_size: 13800000000,
  repository_size: 23800000000,
  lfs_objects_size: 153800000000,
  build_artifacts_size: 3223800000000,
  packages_size: 100000000,
  wiki_size: 238000,
  snippets_size: 30000000,
  pipeline_artifacts_size: 30000000
)
ps.save!

Demo Link

https://gitlab-review-usage-quot-wxujrt.gitlab-review.app/groups/gitlab-qa-sandbox-group/-/usage_quotas#storage-quota-tab

Screenshots

Before After
image image

usage_quota_page

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Mentions: https://gitlab.com/gitlab-org/gitlab/-/issues/247844

Edited by Dhiraj Bodicherla

Merge request reports