Skip to content

Improve the Commit box on the Merge Request Changs tab when browsing per commit

André Luís requested to merge 254706-fix-commit-item-layout-on-mrs into master

What does this MR do?

Fixes:

  • Broken user avatar (should be besides the commit info) (#254706 (closed))
  • Makes the Commit expanded description not bound to the container (it can grow full width) (#240888 (closed))
  • Stacks the commit actions on narrower screen widths
  • Note: It changes the markup order (uses flex to reverse it to the proper visual order): this might affect user navigation, tabbing through the Actions before the Commit link

Screenshots

Before This MR
Screen_Recording_2020-09-28_at_20.46.08_480 Kapture_2020-09-28_at_20.29.51

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #254706 (closed)

Closes #240888 (closed)

Edited by André Luís

Merge request reports