Skip to content

Disable inline editing of license compliance approval

What does this MR do?

Implements #230581 (closed) which has us remove the inline editing (approve/deny) of licenses within the MR and Pipeline/Licenses areas. These actions were asynchronous relying on a backend worker. This created a suboptimal experience as the user was attempting to push forward the MR and couldn't know when the change would be made.

Screenshots

There isn't a visual change in the license widget. The links now go directly to the external license page rather than loading the license management modal.

Before image

After image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #230581 (closed)

Edited by Neil McCorrison

Merge request reports