Resolve "Cannot include downstream pipeline with `include:file`"

What does this MR do?

Related to #205157 (closed)

Allow project: and ref: keys to be used for including files for parent-child pipelines:

images_build_multiple:
  stage: build
  trigger:
    strategy: depend
    include:
      - project: 'my-group/my-pipeline-library'
        ref: 'master'
        file: 'path/to/child-pipeline.yml'

Screenshots

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

changed milestone to %13.5

added Category:Continuous Integration SLOMissed [deprecated] Accepting merge requests backend bridge pipelines customer devopsverify grouppipeline authoring priority2 sectionops severity2 typebug workflowready for development + 1 deleted label

assigned to @mbobin

added 2 commits

• fadf2dc8 - Allow includes:file with project in parent-child pipelines
• 5bef0fa3 - Add changelog entry

Compare with previous version

unmarked as a Work In Progress

changed the description

@furkanayhan could you do the first review here?

assigned to @furkanayhan

	1 Message
	This merge request adds or changes files that require a review from the Technical Writing team.

Documentation review

The following files require a review from a technical writer:

• doc/ci/parent_child_pipelines.md
• doc/ci/yaml/README.md

The review does not need to block merging this merge request. See the:

• Technical Writers assignments for the appropriate technical writer for this review.
• Documentation workflows for information on when to assign a merge request for review.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Category	Reviewer	Maintainer
backend	Tetiana Chupryna (@brytannia) (UTC+3, same timezone as @mbobin)	Fabio Pitino (@fabiopitino) (UTC+2, 1 hour behind @mbobin)

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

@mbobin Nice work! I left a comment about #238592. Also, I have these non-blocking questions:

• What do you think about writing a test using project/file in one of these files?:
  • spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb
  • spec/lib/gitlab/ci/yaml_processor_spec.rb
  • spec/lib/gitlab/ci/config_spec.rb
• Should we create a follow-up documentation issue (or ping @marcel.amirault) to add this new usage into there?: https://docs.gitlab.com/ee/ci/parent_child_pipelines.html

unassigned @furkanayhan

removed [deprecated] Accepting merge requests label

added 200 commits

• 5bef0fa3...0f89e4e0 - 196 commits from branch master
• 52369973 - Allow includes:file with project in parent-child pipelines
• 235eee7e - Add changelog entry
• 1eb3eae6 - Add specs for includes project/file
• 5b50da51 - Add specs for parent-child service with project/file

Compare with previous version

assigned to @furkanayhan

added Technical Writing docsfeature documentation labels

approved this merge request

unassigned @furkanayhan

added 1623 commits

• 5b50da51...38df81e9 - 1618 commits from branch master
• 22efcd4e - Allow includes:file with project in parent-child pipelines
• bfc3e3ce - Add changelog entry
• 6f44a107 - Add specs for includes project/file
• dfe9d2df - Add specs for parent-child service with project/file
• 3a349925 - Add documentation files for child pipelines with include:file

Compare with previous version

added 1 commit

• ddb14833 - Add more examples for parent-child pipelines

Compare with previous version

assigned to @marcel.amirault

@fabiopitino this is ready for maintainer review.

assigned to @fabiopitino

approved this merge request

unassigned @fabiopitino

@mbobin Yeah, I like the way you did it, just want to split out the examples to be separate, if you could take a look?

If you apply the suggestion as-is, feel free to forward it straight to Fabio for merge, you don't need to send it back to me

added twfinished label

unassigned @marcel.amirault

added 1 commit

• b6a24fbc - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit

• 1049c9a5 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

assigned to @fabiopitino and unassigned @mbobin

resolved all threads

enabled an automatic merge when the pipeline for 0778d715 succeeds

aborted the automatic merge because source branch was updated

added 1 commit

• 45f20415 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

resolved all threads

enabled an automatic merge when the pipeline for aa702ddd succeeds

merged

mentioned in commit 938c0352

added workflowstaging label and removed workflowready for development label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

mentioned in issue gitlab-com/www-gitlab-com#8990 (closed)

This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.

---

This comment is generated automatically using the Release Tools project.

added published label

This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.

---

This comment is generated automatically using the Release Tools project.

mentioned in issue #35345 (closed)

mentioned in merge request !70779 (merged)

mentioned in issue #219342

added Category:Pipeline Composition label