Skip to content

Fix namespace problem with dynamic vuex import

euko requested to merge euko-fix-dynamic-import-for-mr-note-store into master

What does this MR do?

  • Fixes the Vue instances initialization for issuable_lock_form.vue

    • After we started using dynamic import, we had to pass in store.default rather than just store in mount_sidebar.js#L145. In this MR, we instead return store.default in the promise returned by the dynamic import.
  • Adds a feature spec to allow us to detect problems earlier.

Issue #255907 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by euko

Merge request reports