Add Gitpod button to MR page (!43352) · Merge requests · GitLab.org / GitLab

The 17.0 major release is coming on May 16, 2024! This version brings many exciting improvements to GitLab, but also removes some deprecated features. We are introducing three breaking change windows during which we expect breaking changes to be deployed to GitLab.com. You can read more about it on our blogpost . The second breaking change window begins 2024-04-29 09:00 UTC and ends 2024-05-01 22:00 UTC.

Cornelius Ludmann requested to merge corneliusludmann/gitlab:gitpod-button-on-mr-page into master Sep 24, 2020

What does this MR do?

Closes #338741 (closed)

EDIT:

This MR does two things:

(minor) It changes the "Open in Web IDE" button to also include "Open in Gitpod", if enabled. This is done simply by replacing the custom button with our standard web_ide_link component.
(major) It changes when we show an enabled "Open in Web IDE" button. Previously, this was only visible and enabled if the user could edit the MR branch. Now, we always show this button. Since the "Open in Web IDE" button was originally added, the Web IDE has been enhanced to gracefully handle a number of different permission states (see relevant issue), such that we shouldn't worry about preventing the user from visiting this page.

Why shouldn't we worry about hiding this button?

The Web IDE will direct the user to a fork, if possible, otherwise it'll display a persistent warning to the user that they are not allowed to make edits. This warning was not available before the button disability was put in place.
Editing / committing is not the only action a user may wish to take with "Open in Web IDE" or "Open in Gitpod". For instance, they may just want to run some tests in Gitpod. The user may just want to create a patch through the Web IDE (coming soon).

ORIGINAL:

This MR adds the Gitpod button introduced in !37985 (merged) to the MR pages (we decided to move this to a separate MR). It uses the same vue component as in the tree header view. That has the following effects:

It harmonizes the code base of the Web IDE button on the tree header view and the MR page. The behavior is now more similar.
However, this also slightly changes the behavior of the Web IDE button on the MR page.

See also the discussions on !37985 (merged), especially !37985 (comment 402770390)

/cc @phikai @pslaughter @mnichols1

Screenshots

EDIT (2021-08-10):

To enable the Gitpod button to show in the dropdown, go to Admin > Settings > Gitpod.

What should I be looking for?

It's expected that users need to "Enable Gitpod" for their user preferences.
If the "Open in Gitpod" button navigates to <gitpod_url>#<merge_request_url> it's working.