Skip to content

Strip deprecations from last_commit.vue

Amy Qualls requested to merge 219860-aqualls-fix-button into master

What does this MR do?

Cleans up a deprecated button as requested in the linked issue. From the screenshot below, it's clear the old icon was not following the standard at https://design.gitlab.com/components/button/#ellipsis. The new icon does match it, and certainly seems to look better.

Closes #219860 (closed)

Screenshots

Before

Screen_Shot_2020-09-25_at_13.28.30

After

Screen_Shot_2020-09-25_at_13.28.01

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #219860 (closed)

Edited by Marcel Amirault

Merge request reports