Allow access to Users Public GPG Keys
What does this MR do?
This change will make the public keys of an individual user accessible without public authentication.
From a security perspective !19952 (comment 386792881):
@m_gill This is OK from a security point of view as public keys are by definition public and according to the docs it does not return any another metadata about the user
Started from a community contribution that would require read_only permissions to access this endpoint, but since these are public keys and the issue itself seems more geared towards pasting links for anyone to access, I changed this to public authentication.
Screenshots
| Before: Without token, or without permission to user | After: Without token, or without permission to user |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team