Skip to content

api: Allow non-admin user to get GPG public keys

Lorenz Leutgeb requested to merge (removed):api-expose-gpg into master

What does this MR do?

Removes the requirement of administration privileges for the endpoint

GET /users/:id/gpg_keys

With this change the scope read_user is now required.

#21584 (closed)

Screenshots

No visual changes/effects.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

I believe that exposing public GPG keys for tokens that have the read_user permission does not pose a significant security threat. GitHub, for example, even exposes them publicly: https://github.com/m-bymike.gpg

@gitlab-com/gl-security/appsec, this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security -> I cannot label the MR.
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

P.S.: This is my first MR for GitLab, please excuse newbie issues...

Edited by 🤖 GitLab Bot 🤖

Merge request reports