Skip to content

Draft: Refactor(profile/preferences): convert to Vue template

What does this MR do?

This MR is in Draft mode

TODO:

  • figure out validation of form submission + flash display
  • finalize haml migration of group_overview_selector using an ee_else_ce/-import
  • finalize haml migration of integration_views with the following sub-templates:
    • app/views/profiles/preferences/_gitpod.html.haml
    • app/views/profiles/preferences/_sourcegraph.html.haml

Same functionality, but different implementation:

  • image lazy load
  • checkbox default value
  • radio button direct submit (all fields)

Differences to HAML implementation:

  • changed select2 to select
  • changed quote in "Show one file at a time on merge request’s Changes tab"
  • added gl-button class to submit
  • changed submit to call submit()

Screenshots

Before: After:
Screen_Shot_2020-10-02_at_16.15.35 Screen_Shot_2020-10-02_at_16.16.49
Screen_Shot_2020-10-02_at_16.13.33 Screen_Shot_2020-10-02_at_16.17.04
Screen_Shot_2020-10-02_at_16.15.33 Screen_Shot_2020-10-02_at_16.19.42

The new page in action:

Screen_Recording_2020-10-02_at_16.17.28

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #250846 (closed)

Edited by Michael Lunøe

Merge request reports