Skip to content

EE: Unify and split CE/EE for spec/requests/api/jobs_spec.rb

Lin Jen-Shin requested to merge 4635-unify-jobs-and-builds-sepc-ee into master

EE for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16804

What does this MR do?

  • spec/requests/api/v3/builds_spec.rb and spec/requests/api/jobs_spec.rb should now be the same in both CE and EE
    • This command should show nothing: git diff ee/4635-unify-jobs-and-builds-sepc-ee ce/4635-unify-jobs-and-builds-sepc spec/requests/api/jobs_spec.rb spec/requests/api/v3/builds_spec.rb
  • The tests removed from above files in EE, should now be replicated in spec/ee/spec/requests/api/v3/builds_spec.rb and spec/ee/spec/requests/api/jobs_spec.rb respectively.

Are there points in the code the reviewer needs to double check?

We don't lose any EE tests.

Why was this MR needed?

To reduce conflicts

Does this MR meet the acceptance criteria?

  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Backend

What are the relevant issue numbers?

Closes #4635 (closed)

Edited by Lin Jen-Shin

Merge request reports

Loading