Resolve resolve_all missing partial
What does this MR do?
Partial was deleted, but reference to it was not in !25506 (merged)
Remove the rendering of the non existent partial. As the resolving is covered by https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/views/discussions/_new_issue_for_discussion.html.haml
Screenshots
Before removing this line, we'd get a 500 error locally and on .com
as noted in #254996:
With the resolve_all partial restored, we can see it upon inspection in the dom, but it is never displayed as it seems to not get past loading stage due to state it is in:
However, I don't think this matters anyway as the https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/views/discussions/_new_issue_for_discussion.html.haml renders(albeit and out of date button setup with our other areas) the resolve button and it works as expected:
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #254996