Skip to content

Resolve resolve_all missing partial

What does this MR do?

Partial was deleted, but reference to it was not in !25506 (merged)

Remove the rendering of the non existent partial. As the resolving is covered by https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/views/discussions/_new_issue_for_discussion.html.haml

Screenshots

Before removing this line, we'd get a 500 error locally and on .com as noted in #254996:

Screen_Shot_2020-09-23_at_1.23.41_PM

With the resolve_all partial restored, we can see it upon inspection in the dom, but it is never displayed as it seems to not get past loading stage due to state it is in:

Screen_Shot_2020-09-23_at_1.51.41_PM

However, I don't think this matters anyway as the https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/views/discussions/_new_issue_for_discussion.html.haml renders(albeit and out of date button setup with our other areas) the resolve button and it works as expected:

Screen_Shot_2020-09-23_at_1.53.20_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #254996

Edited by Doug Stull

Merge request reports