Skip to content

Inherit viewability of incidents from issues

Sarah Yasonik requested to merge sy-allow-guests-to-view-incidents into master

What does this MR do?

In this MR:

  • Drops read_incidents, instead using read_issue directly as incidents should be readable with the same rules as standard issues
  • Ensures the 'Operations' menu shows up for the people it's supposed to (including a few permissions that were missed)

Related issue: https://gitlab.com/gitlab-org/gitlab/-/issues/232750

Screenshots

Note that the "hovered-over" blue incident in the owner view is a confidential issue. This is in a public project.

Menu - anon user Incidents - anon user Menu - owner Incidents - owner
Screen_Shot_2020-09-22_at_6.55.26_PM Screen_Shot_2020-09-22_at_6.55.41_PM Screen_Shot_2020-09-22_at_6.57.30_PM Screen_Shot_2020-09-22_at_6.57.19_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Mayra Cabrera

Merge request reports