Skip to content

Port ci lint from HAML to Vue

Payton Burdette requested to merge port-ci-lint-to-vue-lint-results into master

What does this MR do?

This is the second MR in the process of porting over the CI lint view from HAML to Vue.

The first MR can be found here: !42401 (merged)

In this Merge request, we setup Apollo and a client side resolver that in return calls a REST endpoint until GraphQL has the correct mutations in place. This allows us to go ahead and get the FE architecture in place without refactoring in the future.

We as well build out the lint results, warnings, errors and set up the actions for the view.

In the following MR, we will implement the editor and tie together the lint contents with the actions (lint, dry run, clear).

This feature is behind a feature flag ci_lint_vue and thus does not need a changelog.

Related to: #228884 (closed)

Lint test config used 👇

stages:
  - build
  - test
  - deploy

job_1:
  stage: build
  script: echo 'Building'
  only:
    - web
    - chat
    - pushes
  allow_failure: true

multi_project_job:
  stage: test
  trigger: root/ci-project

microservice_a:
  stage: test
  trigger:
    include: config/microservice_a.yml
job_2:
  script: echo 'job'
  only:
    - branches@gitlab-org/gitlab
  except:
    - master@gitlab-org/gitlab
    - /^release/.*$/@gitlab-org/gitlab

Screenshots

Success

lint-is-good

Success with warning

lint-good-with-warning

Error

lint-with-error

Error and Warning

lint-with-error-warning

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Payton Burdette

Merge request reports