Skip to content

Group members Vue conversion - avatar component

What does this MR do?

Behind the vue_group_members_list feature flag. To enable:

  1. bin/rails console
  2. Feature.enable(:vue_group_members_list)

As part of the effort to convert the group members view from HAML to Vue this MR adds a member_avatar.vue component. To keep MRs small the rest of the table will come in a series of subsequent MRs.

Review app: https://gitlab-review-235605-con-n1ys7b.gitlab-review.app/groups/haml-to-vue-conversion/-/group_members

Screenshots

Desktop

Expand Screen_Shot_2020-09-22_at_9.15.08_AM Screen_Shot_2020-09-22_at_9.16.01_AM Screen_Shot_2020-09-22_at_9.16.17_AM Screen_Shot_2020-09-22_at_9.16.47_AM

Mobile

Expand Screen_Shot_2020-09-22_at_9.18.00_AM Screen_Shot_2020-09-22_at_9.18.31_AM **Will be fixed by gitlab-ui!1735 (merged)** Screen_Shot_2020-09-22_at_9.18.42_AM Screen_Shot_2020-09-22_at_9.19.18_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports