Skip to content

Fixes the diffs rendered output being cached in correctly

Phil Hughes requested to merge ph/fixSingleFileDiffsCachingRenderedOutput into master

What does this MR do?

Fixes a bug with single file diff mode being enabled causing the rendered output of the diffs sometimes getting cached and re-rendered for the incorrect file.

This is fixed by adding a key to each element that uses v-safe-html to force it to always update its contents whenever the line has changed.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports